Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V3 alpha feature/3659 support webview options #3766

Draft
wants to merge 4 commits into
base: v3-alpha
Choose a base branch
from
Draft

V3 alpha feature/3659 support webview options #3766

wants to merge 4 commits into from

Conversation

leaanthony
Copy link
Member

Description

Adds the PasswordAutosaveEnabled and GeneralAutofillEnabled options for Windows.

Fixes #3732

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 21, 2024

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@leaanthony leaanthony changed the base branch from master to v3-alpha September 21, 2024 23:29
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Sep 21, 2024 •
edited
Loading

Deploying wails with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9675313
Status: ✅  Deploy successful!
Preview URL: https://65469d77.wails.pages.dev
Branch Preview URL: https://v3-alpha-feature-3659-suppor.wails.pages.dev

View logs

@semgrep-app semgrep-app
Copy link

semgrep-app bot commented Sep 21, 2024

Semgrep found 1 ssc-912ef774-b507-401f-823e-0eae254d0f22 finding:

  • mkdocs-website/generate/go.mod

Risk: golang.org/x/net versions before 0.7.0 are vulnerable to Uncontrolled Resource Consumption caused by the HPACK decoder. A malformed HTTP/2 Stream could be sufficient to cause a denial of service from a small number of small requests.

Manual Review Advice: A vulnerability from this advisory is reachable if you host a user-facing application utilizing net with the HPACK decoder

Fix: Upgrade this library to at least version 0.7.0 at wails/mkdocs-website/generate/go.mod:33.

Reference(s): GHSA-vvpx-j8f3-3w6h, CVE-2022-41723

Ignore this finding from ssc-912ef774-b507-401f-823e-0eae254d0f22.

Semgrep found 1 ssc-678a0e08-5ae8-47ab-b49c-8d3eb7d55fee finding:

  • mkdocs-website/generate/go.mod

Risk: Affected versions of github.com/go-git/go-git/v5 are vulnerable to Uncontrolled Resource Consumption. The vulnerability enables attackers to execute denial-of-service attacks by exploiting specially crafted responses from a malicious Git server, leading to resource exhaustion in go-git clients.

Manual Review Advice: A vulnerability from this advisory is reachable if you are using go-git to communicate with untrusted servers and are not using the in-memory filesystem for storage

Fix: Upgrade this library to at least version 5.11.0 at wails/mkdocs-website/generate/go.mod:15.

Reference(s): GHSA-mw99-9chc-xw7r, CVE-2023-49568

Ignore this finding from ssc-678a0e08-5ae8-47ab-b49c-8d3eb7d55fee.

Semgrep found 1 ssc-efa14576-9601-4ae6-939c-3da58aa25013 finding:

  • v3/examples/dev/frontend/package-lock.json

Risk: Affected versions of vite are vulnerable to Improper Handling Of Case Sensitivity / Exposure Of Sensitive Information To An Unauthorized Actor / Improper Access Control. The vulnerability arises when the Vite development server's option, server.fs.deny, can be circumvented on case-insensitive file systems through the utilization of case-augmented versions of filenames, as the matcher derived from config.server.fs.deny fails to prevent access to sensitive files when raw filesystem paths are requested with augmented casing.

Manual Review Advice: A vulnerability from this advisory is reachable if you host vite's development server on Windows, and you rely on server.fs.deny to deny access to certain files

Fix: Upgrade this library to at least version 4.5.2 at wails/v3/examples/dev/frontend/package-lock.json:615.

Reference(s): GHSA-c24v-8rfc-w8vw, CVE-2023-34092, CVE-2024-23331

Ignore this finding from ssc-efa14576-9601-4ae6-939c-3da58aa25013.

Semgrep found 1 ssc-59363580-1c3f-4351-96ad-c59c611f9c64 finding:

  • mkdocs-website/generate/go.mod

Risk: Affected versions of golang.org/x/net are vulnerable to Uncontrolled Resource Consumption. The HTTP/2 vulnerability occurs when a malicious client rapidly creates and resets requests, causing excessive server resource consumption. Despite the MaxConcurrentStreams setting limiting the total requests, resetting an ongoing request enables the attacker to initiate a new request concurrently.

Fix: Upgrade this library to at least version 0.17.0 at wails/mkdocs-website/generate/go.mod:33.

Reference(s): GHSA-4374-p667-p6c8, CVE-2023-39325

Ignore this finding from ssc-59363580-1c3f-4351-96ad-c59c611f9c64.

Semgrep found 7 ssc-46663897-ab0c-04dc-126b-07fe2ce42fb2 findings:

Risk: Affected versions of golang.org/x/net, golang.org/x/net/http2, and net/http are vulnerable to Uncontrolled Resource Consumption. An attacker may cause an HTTP/2 endpoint to read arbitrary amounts of header data by sending an excessive number of CONTINUATION frames.

Fix: Upgrade this library to at least version 0.23.0 at wails/v3/plugins/experimental/oauth/go.mod:52.

Reference(s): GHSA-4v7x-pqxf-cx7m, CVE-2023-45288

Ignore this finding from ssc-46663897-ab0c-04dc-126b-07fe2ce42fb2.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable autofill passwords
1 participant
@leaanthony